Skip to content

uucore: simplify fallback when splice failed#11921

Merged
cakebaker merged 1 commit intouutils:mainfrom
oech3:s-drain
Apr 21, 2026
Merged

uucore: simplify fallback when splice failed#11921
cakebaker merged 1 commit intouutils:mainfrom
oech3:s-drain

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 20, 2026

Closes #11815

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 20, 2026 •
edited
Loading

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

@oech3 oech3 marked this pull request as ready for review April 20, 2026 16:07
@cakebaker cakebaker merged commit 50957e1 into uutils:main Apr 21, 2026
166 of 167 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Apr 21, 2026

Thanks!

@oech3 oech3 deleted the s-drain branch April 21, 2026 07:41
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 21, 2026

This fn is very near with

coreutils/src/uu/cat/src/splice.rs

Line 20 in 50957e1

pub(super) fn write_fast_using_splice<R: FdReadable, S: AsRawFd + AsFd + Write>(
now. But I cannot dedup yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @cakebaker